X-Git-Url: http://git.cielonegro.org/gitweb.cgi?a=blobdiff_plain;f=Network%2FHTTP%2FLucu%2FMultipartForm.hs;h=7d0866cd4225fe0ec54f8c77f84a01fc24e5dbe6;hb=6126eb9;hp=7ddcbd0f707e144a2ed450a053ee32fd0566d7fd;hpb=4498b6a9091bebb38a92a730b7abff40833e3ed2;p=Lucu.git

diff --git a/Network/HTTP/Lucu/MultipartForm.hs b/Network/HTTP/Lucu/MultipartForm.hs
index 7ddcbd0..7d0866c 100644
--- a/Network/HTTP/Lucu/MultipartForm.hs
+++ b/Network/HTTP/Lucu/MultipartForm.hs
@@ -1,6 +1,7 @@
 {-# LANGUAGE
     DoAndIfThenElse
   , OverloadedStrings
+  , RecordWildCards
   , ScopedTypeVariables
   , UnicodeSyntax
   #-}
@@ -10,22 +11,19 @@ module Network.HTTP.Lucu.MultipartForm
     )
     where
 import Control.Applicative hiding (many)
-import Data.Ascii (Ascii, CIAscii, AsciiBuilder)
+import Data.Ascii (Ascii, CIAscii)
 import qualified Data.Ascii as A
 import Data.Attoparsec.Char8
 import qualified Data.ByteString.Char8 as BS
 import qualified Data.ByteString.Lazy.Char8 as LS
-import Data.Char
-import Data.List
 import Data.Map (Map)
+import qualified Data.Map as M
 import Data.Maybe
 import Data.Monoid.Unicode
 import Data.Text (Text)
 import Network.HTTP.Lucu.Headers
 import Network.HTTP.Lucu.Parser.Http
 import Network.HTTP.Lucu.RFC2231
-import Network.HTTP.Lucu.Response
-import Network.HTTP.Lucu.Utils
 import Prelude.Unicode
 
 -- |This data type represents a form value and possibly an uploaded
@@ -55,7 +53,7 @@ data ContDispo
 
 printContDispo ∷ ContDispo → Ascii
 printContDispo d
-    = A.fromAsciiBuilder $
+    = A.fromAsciiBuilder
       ( A.toAsciiBuilder (A.fromCIAscii $ dType d)
         ⊕
         printParams (dParams d) )
@@ -94,7 +92,7 @@ partToFormPair ∷ Monad m ⇒ Part → m (Maybe (Text, FormData))
 {-# INLINEABLE partToFormPair #-}
 partToFormPair pt
     | dType (ptContDispo pt) ≡ "form-data"
-        = do name  ← partName pt
+        = do name ← partName pt
              let fname = partFileName pt
              let fd    = FormData {
                            fdFileName = fname
@@ -106,25 +104,25 @@ partToFormPair pt
 
 partName ∷ Monad m ⇒ Part → m Text
 {-# INLINEABLE partName #-}
-partName pt
-    = case find ((≡ "name") ∘ fst) $ dParams $ ptContDispo pt of
-        Just (_, name)
+partName (Part {..})
+    = case M.lookup "name" $ dParams ptContDispo of
+        Just name
             → return name
         Nothing
             → fail ("form-data without name: " ⧺
-                    A.toString (printContDispo $ ptContDispo pt))
+                    A.toString (printContDispo ptContDispo))
 
 partFileName ∷ Part → Maybe Text
 {-# INLINEABLE partFileName #-}
-partFileName pt
-    = snd <$> (find ((== "filename") ∘ fst) $ dParams $ ptContDispo pt)
+partFileName (Part {..})
+    = M.lookup "filename" $ dParams ptContDispo
 
 getContDispo ∷ Monad m ⇒ Headers → m ContDispo
 {-# INLINEABLE getContDispo #-}
 getContDispo hdr
     = case getHeader "Content-Disposition" hdr of
         Nothing
-            → fail ("There is a part without Content-Disposition in the multipart/form-data.")
+            → fail "There is a part without Content-Disposition in the multipart/form-data."
         Just str
             → let p  = do d ← contDispoP
                           endOfInput
@@ -141,14 +139,5 @@ getContDispo hdr
 
 contDispoP ∷ Parser ContDispo
 contDispoP = do dispoType ← A.toCIAscii <$> token
-                params    ← many paramP
+                params    ← paramsP
                 return $ ContDispo dispoType params
-    where
-      paramP ∷ Parser (CIAscii, Ascii)
-      paramP = do skipMany lws
-                  _     ← char ';'
-                  skipMany lws
-                  name  ← A.toCIAscii <$> token
-                  _     ← char '='
-                  value ← token <|> quotedStr
-                  return (name, value)