X-Git-Url: http://git.cielonegro.org/gitweb.cgi?a=blobdiff_plain;f=Network%2FHTTP%2FLucu%2FUtils.hs;h=0c29836592e72be3354bf6e6fc2826f5cd666ace;hb=0dc3d31312a12f2b085242841b29eb0d96e9c4ac;hp=d7ace3f8309aab60c21f2c8c6c4362189a05bc73;hpb=0b4db5681e3b0b27357a87316822ea3671f8c174;p=Lucu.git

diff --git a/Network/HTTP/Lucu/Utils.hs b/Network/HTTP/Lucu/Utils.hs
index d7ace3f..0c29836 100644
--- a/Network/HTTP/Lucu/Utils.hs
+++ b/Network/HTTP/Lucu/Utils.hs
@@ -5,50 +5,66 @@ module Network.HTTP.Lucu.Utils
     , joinWith
     , trim
     , noCaseEq
+    , noCaseEq'
     , isWhiteSpace
     , quoteStr
     , parseWWWFormURLEncoded
     )
     where
 
-import Control.Monad.Trans
 import Data.Char
 import Data.List
-import Foreign
-import Foreign.C
 import Network.URI
 
 -- |> splitBy (== ':') "ab:c:def"
 --  > ==> ["ab", "c", "def"]
 splitBy :: (a -> Bool) -> [a] -> [[a]]
 splitBy isSeparator src
-    = case break isSeparator src
+    = isSeparator `seq`
+      case break isSeparator src
       of (last , []      ) -> last  : []
          (first, sep:rest) -> first : splitBy isSeparator rest
 
--- |> joinWith ':' ["ab", "c", "def"]
+-- |> joinWith ":" ["ab", "c", "def"]
 --  > ==> "ab:c:def"
 joinWith :: [a] -> [[a]] -> [a]
 joinWith separator xs
-    = foldr (++) [] $ intersperse separator xs
+    = separator `seq` xs `seq`
+      foldr (++) [] $! intersperse separator xs
 
 -- |> trim (== '_') "__ab_c__def___"
 --  > ==> "ab_c__def"
 trim :: (a -> Bool) -> [a] -> [a]
-trim p = trimTail . trimHead
+trim p = p `seq` trimTail . trimHead
     where
       trimHead = dropWhile p
       trimTail = reverse . trimHead . reverse
 
--- |@'noCaseEq' a b@ is equivalent to @(map toLower a) == (map toLower
--- b)@
+-- |@'noCaseEq' a b@ is equivalent to @('Prelude.map'
+-- 'Data.Char.toLower' a) == ('Prelude.map' 'Data.Char.toLower'
+-- b)@. See 'noCaseEq''.
 noCaseEq :: String -> String -> Bool
 noCaseEq a b
     = (map toLower a) == (map toLower b)
+{-# INLINE noCaseEq #-}
 
--- |@'isWhiteSpace' c@ is True iff c is one of SP, HT, CR and LF.
+-- |@'noCaseEq'' a b@ is a variant of 'noCaseEq' which first checks
+-- the length of two strings to avoid possibly unnecessary comparison.
+noCaseEq' :: String -> String -> Bool
+noCaseEq' a b
+    | length a /= length b = False
+    | otherwise            = noCaseEq a b
+{-# INLINE noCaseEq' #-}
+
+-- |@'isWhiteSpace' c@ is 'Prelude.True' iff c is one of SP, HT, CR
+-- and LF.
 isWhiteSpace :: Char -> Bool
-isWhiteSpace = flip elem " \t\r\n"
+isWhiteSpace ' '  = True
+isWhiteSpace '\t' = True
+isWhiteSpace '\r' = True
+isWhiteSpace '\n' = True
+isWhiteSpace _    = False
+{-# INLINE isWhiteSpace #-}
 
 -- |> quoteStr "abc"
 --  > ==> "\"abc\""
@@ -56,7 +72,8 @@ isWhiteSpace = flip elem " \t\r\n"
 --  > quoteStr "ab\"c"
 --  > ==> "\"ab\\\"c\""
 quoteStr :: String -> String
-quoteStr str = foldr (++) "" (["\""] ++ map quote str ++ ["\""])
+quoteStr str = str `seq`
+               foldr (++) "" (["\""] ++ map quote str ++ ["\""])
     where
       quote :: Char -> String
       quote '"' = "\\\""
@@ -69,7 +86,9 @@ parseWWWFormURLEncoded :: String -> [(String, String)]
 parseWWWFormURLEncoded src
     | src == "" = []
     | otherwise = do pairStr <- splitBy (\ c -> c == ';' || c == '&') src
-                     let pair = break (== '=') pairStr
-                     return ( unEscapeString $ fst pair
-                            , unEscapeString $ snd pair
+                     let (key, value) = break (== '=') pairStr
+                     return ( unEscapeString key
+                            , unEscapeString $ case value of
+                                                 ('=':val) -> val
+                                                 ""        -> ""
                             )