]> gitweb @ CieloNegro.org - youtube-dl.git/commitdiff
Simplify RedTube
authorPhilipp Hagemeister <phihag@phihag.de>
Fri, 3 May 2013 18:07:35 +0000 (20:07 +0200)
committerPhilipp Hagemeister <phihag@phihag.de>
Fri, 3 May 2013 18:07:35 +0000 (20:07 +0200)
test/tests.json
youtube_dl/InfoExtractors.py
youtube_dl/__init__.py

index 6013a13ab38d6a9c494609255cc597f2382a21e2..2d49495d29221c118c32a42014e91f050a87d32f 100644 (file)
     }
   },
   {
-    "name": "Redtube",
+    "name": "RedTube",
     "url": "http://www.redtube.com/66418",
     "file": "66418.mp4",
     "md5": "7b8c22b5e7098a3e1c09709df1126d2d",
index 8b2442bacc21e86db7ffdc920116b51e79fd3820..7d4a60cc8226ea5b99dc543733690156e02d024d 100755 (executable)
@@ -4183,31 +4183,29 @@ class BandcampIE(InfoExtractor):
 
         return [track_info]
 
-class RedtubeIE(InfoExtractor):
+class RedTubeIE(InfoExtractor):
     """Information Extractor for redtube"""
     _VALID_URL = r'(?:http://)?(?:www\.)?redtube\.com/(?P<id>[0-9]+)'
-    IE_NAME = u'redtube'
 
     def _real_extract(self,url):
         mobj = re.match(self._VALID_URL, url)
         if mobj is None:
-            self._downloader.report_error(u'invalid URL: %s' % url)
-            return
+            raise ExtractorError(u'Invalid URL: %s' % url)
+
         video_id = mobj.group('id')
         video_extension = 'mp4'        
         webpage = self._download_webpage(url, video_id)
         self.report_extraction(video_id)
         mobj = re.search(r'<source src="'+'(.+)'+'" type="video/mp4">',webpage)
-        if mobj is not None:
-            video_url = mobj.group(1)
-        else:
-            self._downloader.report_error(u'unable to extract media URL')
-            return
-        mobj = re.search('<h1 class="videoTitle slidePanelMovable">'+r'(.+)'+r'</h1>',webpage)
-        if mobj is not None:
-            video_title = mobj.group(1)
-        else:
-            video_title = 'Redtube - %s' % time.ctime()
+
+        if mobj is None:
+            raise ExtractorError(u'Unable to extract media URL')
+
+        video_url = mobj.group(1)
+        mobj = re.search('<h1 class="videoTitle slidePanelMovable">(.+)</h1>',webpage)
+        if mobj is None:
+            raise ExtractorError(u'Unable to extract title')
+        video_title = mobj.group(1)
 
         return [{
             'id':       video_id,
@@ -4272,7 +4270,7 @@ def gen_extractors():
         ARDIE(),
         TumblrIE(),
         BandcampIE(),
-        RedtubeIE(),
+        RedTubeIE(),
         GenericIE()
     ]
 
index 808d4a8c2c4109f274e9ab4c61b2742db41c1149..823ca63a48cd72a888f8908e7de33ff2774b23a2 100644 (file)
@@ -388,7 +388,8 @@ def _real_main(argv=None):
         if 'http' in proxies and 'https' not in proxies:
             proxies['https'] = proxies['http']
     proxy_handler = compat_urllib_request.ProxyHandler(proxies)
-    opener = compat_urllib_request.build_opener(proxy_handler, cookie_processor, YoutubeDLHandler())
+    https_handler = compat_urllib_request.HTTPSHandler()
+    opener = compat_urllib_request.build_opener(https_handler, proxy_handler, cookie_processor, YoutubeDLHandler())
     compat_urllib_request.install_opener(opener)
     socket.setdefaulttimeout(300) # 5 minutes should be enough (famous last words)