From: Philipp Hagemeister <phihag@phihag.de>
Date: Mon, 2 Feb 2015 19:33:23 +0000 (+0100)
Subject: [downloader/external] Simplify source_address
X-Git-Url: http://git.cielonegro.org/gitweb.cgi?a=commitdiff_plain;h=cc9ca3ba6e0ba24b318ef191fdf84927e773008d;hp=ea71034bd3965de8ff7239516776296e2c9857c3;p=youtube-dl.git

[downloader/external] Simplify source_address

'' might actually be passed in, so check for None.
---

diff --git a/youtube_dl/downloader/external.py b/youtube_dl/downloader/external.py
index faac11805..ff031d2e0 100644
--- a/youtube_dl/downloader/external.py
+++ b/youtube_dl/downloader/external.py
@@ -46,11 +46,10 @@ class ExternalFD(FileDownloader):
         return info_dict['protocol'] in ('http', 'https', 'ftp', 'ftps')
 
     def _source_address(self, command_option):
-        command_part = []
         source_address = self.params.get('source_address')
-        if source_address:
-            command_part = [command_option, source_address]
-        return command_part
+        if source_address is None:
+            return []
+        return [command_option, source_address]
 
     def _call_downloader(self, tmpfilename, info_dict):
         """ Either overwrite this or implement _make_cmd """