From: Sergey M․ <dstftw@gmail.com>
Date: Wed, 9 Aug 2017 15:28:19 +0000 (+0700)
Subject: [utils] Skip missing params in cli_bool_option (closes #13865)
X-Git-Url: https://git.cielonegro.org/gitweb.cgi?a=commitdiff_plain;h=5b232f46dcbdc805507c02edd4fd598f31d544d5;p=youtube-dl.git

[utils] Skip missing params in cli_bool_option (closes #13865)
---

diff --git a/test/test_utils.py b/test/test_utils.py
index 7803e5bc7..2aab16b97 100644
--- a/test/test_utils.py
+++ b/test/test_utils.py
@@ -1182,6 +1182,10 @@ part 3</font></u>
             cli_bool_option(
                 {'nocheckcertificate': False}, '--check-certificate', 'nocheckcertificate', 'false', 'true', '='),
             ['--check-certificate=true'])
+        self.assertEqual(
+            cli_bool_option(
+                {}, '--check-certificate', 'nocheckcertificate', 'false', 'true', '='),
+            [])
 
     def test_ohdave_rsa_encrypt(self):
         N = 0xab86b6371b5318aaa1d3c9e612a9f1264f372323c8c0f19875b5fc3b3fd3afcc1e5bec527aa94bfa85bffc157e4245aebda05389a5357b75115ac94f074aefcd
diff --git a/youtube_dl/utils.py b/youtube_dl/utils.py
index fdf5e29e7..c9cbd5842 100644
--- a/youtube_dl/utils.py
+++ b/youtube_dl/utils.py
@@ -2733,6 +2733,8 @@ def cli_option(params, command_option, param):
 
 def cli_bool_option(params, command_option, param, true_value='true', false_value='false', separator=None):
     param = params.get(param)
+    if param is None:
+        return []
     assert isinstance(param, bool)
     if separator:
         return [command_option + separator + (true_value if param else false_value)]